refactor: introduce type-only imports (#5462)

packages/netlify-cms-backend-gitlab/src/API.ts

@@ -1,3 +1,10 @@
+import type {
+  ApiRequest,
+  DataFile,
+  AssetProxy,
+  PersistOptions,
+  FetchError,
+} from 'netlify-cms-lib-util';
 import {
   localForage,
   parseLinkHeader,
@@ -5,10 +12,6 @@ import {
   then,
   APIError,
   Cursor,
-  ApiRequest,
-  DataFile,
-  AssetProxy,
-  PersistOptions,
   readFile,
   CMS_BRANCH_PREFIX,
   generateContentKey,
@@ -24,7 +27,6 @@ import {
   branchFromContentKey,
   requestWithBackoff,
   readFileMetadata,
-  FetchError,
   throwOnConflictingBranches,
 } from 'netlify-cms-lib-util';
 import { Base64 } from 'js-base64';
@@ -301,7 +303,6 @@ export default class API {
       try {
         const result: GitLabCommit[] = await this.requestJSON({
           url: `${this.repoURL}/repository/commits`,
-          // eslint-disable-next-line @typescript-eslint/camelcase
           params: { path, ref_name: this.branch },
         });
         const commit = result[0];
@@ -396,7 +397,6 @@ export default class API {
     let { cursor, entries: initialEntries } = await this.fetchCursorAndEntries({
       url: `${this.repoURL}/repository/tree`,
       // Get the maximum number of entries per page
-      // eslint-disable-next-line @typescript-eslint/camelcase
       params: { path, ref: branch, per_page: 100, recursive },
     });
     entries.push(...initialEntries);
@@ -425,9 +425,7 @@ export default class API {
   ) {
     const actions = items.map(item => ({
       action: item.action,
-      // eslint-disable-next-line @typescript-eslint/camelcase
       file_path: item.path,
-      // eslint-disable-next-line @typescript-eslint/camelcase
       ...(item.oldPath ? { previous_path: item.oldPath } : {}),
       ...(item.base64Content !== undefined
         ? { content: item.base64Content, encoding: 'base64' }
@@ -436,17 +434,13 @@ export default class API {
 
     const commitParams: CommitsParams = {
       branch,
-      // eslint-disable-next-line @typescript-eslint/camelcase
       commit_message: commitMessage,
       actions,
-      // eslint-disable-next-line @typescript-eslint/camelcase
       ...(newBranch ? { start_branch: this.branch } : {}),
     };
     if (this.commitAuthor) {
       const { name, email } = this.commitAuthor;
-      // eslint-disable-next-line @typescript-eslint/camelcase
       commitParams.author_name = name;
-      // eslint-disable-next-line @typescript-eslint/camelcase
       commitParams.author_email = email;
     }
 
@@ -528,13 +522,10 @@ export default class API {
 
   deleteFiles = (paths: string[], commitMessage: string) => {
     const branch = this.branch;
-    // eslint-disable-next-line @typescript-eslint/camelcase
     const commitParams: CommitsParams = { commit_message: commitMessage, branch };
     if (this.commitAuthor) {
       const { name, email } = this.commitAuthor;
-      // eslint-disable-next-line @typescript-eslint/camelcase
       commitParams.author_name = name;
-      // eslint-disable-next-line @typescript-eslint/camelcase
       commitParams.author_email = email;
     }
 
@@ -551,9 +542,7 @@ export default class API {
         state: 'opened',
         labels: 'Any',
         per_page: 100,
-        // eslint-disable-next-line @typescript-eslint/camelcase
         target_branch: this.branch,
-        // eslint-disable-next-line @typescript-eslint/camelcase
         ...(sourceBranch ? { source_branch: sourceBranch } : {}),
       },
     });
@@ -686,7 +675,6 @@ export default class API {
       rebase = await this.requestJSON({
         url: `${this.repoURL}/merge_requests/${mergeRequest.iid}`,
         params: {
-          // eslint-disable-next-line @typescript-eslint/camelcase
           include_rebase_in_progress: true,
         },
       });
@@ -708,14 +696,11 @@ export default class API {
       method: 'POST',
       url: `${this.repoURL}/merge_requests`,
       params: {
-        // eslint-disable-next-line @typescript-eslint/camelcase
         source_branch: branch,
-        // eslint-disable-next-line @typescript-eslint/camelcase
         target_branch: this.branch,
         title: commitMessage,
         description: DEFAULT_PR_BODY,
         labels: statusToLabel(status, this.cmsLabelPrefix),
-        // eslint-disable-next-line @typescript-eslint/camelcase
         remove_source_branch: true,
         squash: this.squashMerges,
       },
@@ -790,12 +775,9 @@ export default class API {
       method: 'PUT',
       url: `${this.repoURL}/merge_requests/${mergeRequest.iid}/merge`,
       params: {
-        // eslint-disable-next-line @typescript-eslint/camelcase
         merge_commit_message: MERGE_COMMIT_MESSAGE,
-        // eslint-disable-next-line @typescript-eslint/camelcase
         squash_commit_message: MERGE_COMMIT_MESSAGE,
         squash: this.squashMerges,
-        // eslint-disable-next-line @typescript-eslint/camelcase
         should_remove_source_branch: true,
       },
     });
@@ -813,7 +795,6 @@ export default class API {
       method: 'PUT',
       url: `${this.repoURL}/merge_requests/${mergeRequest.iid}`,
       params: {
-        // eslint-disable-next-line @typescript-eslint/camelcase
         state_event: 'close',
       },
     });
@@ -864,11 +845,9 @@ export default class API {
     const branch = branchFromContentKey(contentKey);
     const mergeRequest = await this.getBranchMergeRequest(branch);
     const statuses: GitLabCommitStatus[] = await this.getMergeRequestStatues(mergeRequest, branch);
-    // eslint-disable-next-line @typescript-eslint/camelcase
     return statuses.map(({ name, status, target_url }) => ({
       context: name,
       state: status === GitLabCommitStatuses.Success ? PreviewState.Success : PreviewState.Other,
-      // eslint-disable-next-line @typescript-eslint/camelcase
       target_url,
     }));
   }

packages/netlify-cms-backend-gitlab/src/implementation.ts

@@ -1,29 +1,32 @@
 import trimStart from 'lodash/trimStart';
-import semaphore, { Semaphore } from 'semaphore';
+import type { Semaphore } from 'semaphore';
+import semaphore from 'semaphore';
 import { trim } from 'lodash';
 import { stripIndent } from 'common-tags';
-import {
-  CURSOR_COMPATIBILITY_SYMBOL,
-  basename,
+import type {
   Entry,
   AssetProxy,
   PersistOptions,
   Cursor,
   Implementation,
   DisplayURL,
-  entriesByFolder,
-  entriesByFiles,
-  getMediaDisplayURL,
-  getMediaAsBlob,
   User,
   Credentials,
   Config,
   ImplementationFile,
+  UnpublishedEntryMediaFile,
+  AsyncLock,
+} from 'netlify-cms-lib-util';
+import {
+  CURSOR_COMPATIBILITY_SYMBOL,
+  basename,
+  entriesByFolder,
+  entriesByFiles,
+  getMediaDisplayURL,
+  getMediaAsBlob,
   unpublishedEntries,
   getPreviewStatus,
-  UnpublishedEntryMediaFile,
   asyncLock,
-  AsyncLock,
   runWithLock,
   getBlobSHA,
   blobToFileObj,
@@ -178,7 +181,7 @@ export default class GitLab implements Implementation {
       this.api!.readFileMetadata.bind(this.api),
       API_NAME,
     );
-    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
     files[CURSOR_COMPATIBILITY_SYMBOL] = cursor;
     return files;