fix(core): don't pass boolean value to string prop, use null instead (#2609)

This commit is contained in:
Erez Rokah 2019-09-05 01:39:21 +03:00 committed by Shawn Erquhart
parent 5b64e25d07
commit ce95a774b2

View File

@ -401,12 +401,12 @@ class EditorToolbar extends React.Component {
<StatusDropdownItem <StatusDropdownItem
label={t('editor.editorToolbar.draft')} label={t('editor.editorToolbar.draft')}
onClick={() => onChangeStatus('DRAFT')} onClick={() => onChangeStatus('DRAFT')}
icon={currentStatus === status.get('DRAFT') && 'check'} icon={currentStatus === status.get('DRAFT') ? 'check' : null}
/> />
<StatusDropdownItem <StatusDropdownItem
label={t('editor.editorToolbar.inReview')} label={t('editor.editorToolbar.inReview')}
onClick={() => onChangeStatus('PENDING_REVIEW')} onClick={() => onChangeStatus('PENDING_REVIEW')}
icon={currentStatus === status.get('PENDING_REVIEW') && 'check'} icon={currentStatus === status.get('PENDING_REVIEW') ? 'check' : null}
/> />
{useOpenAuthoring ? ( {useOpenAuthoring ? (
'' ''
@ -414,7 +414,7 @@ class EditorToolbar extends React.Component {
<StatusDropdownItem <StatusDropdownItem
label={t('editor.editorToolbar.ready')} label={t('editor.editorToolbar.ready')}
onClick={() => onChangeStatus('PENDING_PUBLISH')} onClick={() => onChangeStatus('PENDING_PUBLISH')}
icon={currentStatus === status.get('PENDING_PUBLISH') && 'check'} icon={currentStatus === status.get('PENDING_PUBLISH') ? 'check' : null}
/> />
)} )}
</ToolbarDropdown> </ToolbarDropdown>