gcg/static-cms
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: change getAsset to not return a promise (#3232)

Browse Source 
* fix: change getAsset to not return a promise

* fix: update markdown widget per getAsset changes

* test: fix editor component image test

* docs: update getAsset docs
This commit is contained in:
Erez Rokah
2020-02-13 02:12:36 +02:00
committed by GitHub
parent 2457c29baf
commit ab685e8594
30 changed files with 317 additions and 355 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/netlify-cms-editor-component-image/src/__tests__/index.spec.js
View File

@ -1,6 +1,6 @@
import component from '../index';
const getAsset = path => Promise.resolve(path);
const getAsset = path => path;
const image = '/image';
const alt = 'alt';
const title = 'title';
@ -32,8 +32,8 @@ describe('editor component image', () => {
);
});
it('should generate valid react props', async () => {
await expect(component.toPreview({ image, alt, title }, getAsset)).resolves.toMatchObject({
it('should generate valid react props', () => {
expect(component.toPreview({ image, alt, title }, getAsset)).toMatchObject({
props: { src: image, alt, title },
});
});

4
packages/netlify-cms-editor-component-image/src/index.js
View File

@ -12,10 +12,10 @@ const image = {
toBlock: ({ alt, image, title }) =>
`![${alt || ''}](${image || ''}${title ? ` "${title.replace(/"/g, '\\"')}"` : ''})`,
// eslint-disable-next-line react/display-name
toPreview: async ({ alt, image, title }, getAsset, fields) => {
toPreview: ({ alt, image, title }, getAsset, fields) => {
const imageField = fields?.find(f => f.get('widget') === 'image');
const folder = imageField?.get('media_folder');
const src = await getAsset(image, folder);
const src = getAsset(image, folder);
return <img src={src || ''} alt={alt || ''} title={title || ''} />;
},
pattern: /^!\[(.*)\]\((.*?)(\s"(.*)")?\)$/,