gcg/static-cms
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(a11y): correct label "for" references to fields (#1904)

Browse Source
This commit is contained in:
Alexander Nanberg
2018-11-26 17:56:41 +01:00
committed by Shawn Erquhart
parent 422d0cbe2f
commit 955f94f72b
5 changed files with 23 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/netlify-cms-core/src/components/Editor/EditorControlPane/EditorControl.js
View File

@ -150,6 +150,8 @@ class EditorControl extends React.Component {
activeLabel: false,
};
uniqueFieldId = uniqueId(`${this.props.field.get('name')}-field-`);
render() {
const {
value,
@ -176,7 +178,6 @@ class EditorControl extends React.Component {
const widget = resolveWidget(widgetName);
const fieldName = field.get('name');
const fieldHint = field.get('hint');
const uniqueFieldId = uniqueId();
const metadata = fieldsMetaData && fieldsMetaData.get(fieldName);
const errors = fieldsErrors && fieldsErrors.get(fieldName);
return (
@ -197,7 +198,7 @@ class EditorControl extends React.Component {
{ [styles.labelActive]: this.state.styleActive },
{ [styles.labelError]: !!errors },
)}
htmlFor={fieldName + uniqueFieldId}
htmlFor={this.uniqueFieldId}
>
{field.get('label', field.get('name'))}
</label>
@ -213,7 +214,7 @@ class EditorControl extends React.Component {
classNameLabelActive={styles.labelActive}
controlComponent={widget.control}
field={field}
uniqueFieldId={uniqueFieldId}
uniqueFieldId={this.uniqueFieldId}
value={value}
mediaPaths={mediaPaths}
metadata={metadata}

2
packages/netlify-cms-core/src/components/Editor/EditorControlPane/Widget.js
View File

@ -237,7 +237,7 @@ export default class Widget extends Component {
onAddAsset,
onRemoveInsertedMedia,
getAsset,
forID: field.get('name') + uniqueFieldId,
forID: uniqueFieldId,
ref: this.processInnerControlRef,
classNameWrapper,
classNameWidget,