fix: deprecate inconsistent config param case (#4172)
This commit is contained in:
@ -69,7 +69,7 @@ export default class NumberControl extends React.Component {
|
||||
};
|
||||
|
||||
handleChange = e => {
|
||||
const valueType = this.props.field.get('valueType');
|
||||
const valueType = this.props.field.get('value_type');
|
||||
const { onChange } = this.props;
|
||||
const value = valueType === 'float' ? parseFloat(e.target.value) : parseInt(e.target.value, 10);
|
||||
|
||||
@ -99,7 +99,7 @@ export default class NumberControl extends React.Component {
|
||||
const { field, value, classNameWrapper, forID, setActiveStyle, setInactiveStyle } = this.props;
|
||||
const min = field.get('min', '');
|
||||
const max = field.get('max', '');
|
||||
const step = field.get('step', field.get('valueType') === 'int' ? 1 : '');
|
||||
const step = field.get('step', field.get('value_type') === 'int' ? 1 : '');
|
||||
return (
|
||||
<input
|
||||
type="number"
|
||||
|
@ -10,7 +10,7 @@ const fieldSettings = {
|
||||
min: -20,
|
||||
max: 20,
|
||||
step: 1,
|
||||
valueType: 'int',
|
||||
value_type: 'int',
|
||||
};
|
||||
|
||||
class NumberController extends React.Component {
|
||||
@ -120,7 +120,7 @@ describe('Number widget', () => {
|
||||
});
|
||||
|
||||
it('should parse float numbers as float', () => {
|
||||
const field = fromJS({ ...fieldSettings, valueType: 'float' });
|
||||
const field = fromJS({ ...fieldSettings, value_type: 'float' });
|
||||
const testValue = (Math.random() * (20 - -20 + 1) + -20).toFixed(2);
|
||||
const { input, onChangeSpy } = setup({ field });
|
||||
|
||||
|
@ -1,7 +1,7 @@
|
||||
export default {
|
||||
properties: {
|
||||
step: { type: 'number' },
|
||||
valueType: { type: 'string' },
|
||||
value_type: { type: 'string' },
|
||||
min: { type: 'number' },
|
||||
max: { type: 'number' },
|
||||
},
|
||||
|
Reference in New Issue
Block a user