Feat: editorial workflow bitbucket gitlab (#3014)

* refactor: typescript the backends

* feat: support multiple files upload for GitLab and BitBucket

* fix: load entry media files from media folder or UI state

* chore: cleanup log message

* chore: code cleanup

* refactor: typescript the test backend

* refactor: cleanup getEntry unsued variables

* refactor: moved shared backend code to lib util

* chore: rename files to preserve history

* fix: bind readFile method to API classes

* test(e2e): switch to chrome in cypress tests

* refactor: extract common api methods

* refactor: remove most of immutable js usage from backends

* feat(backend-gitlab): initial editorial workflow support

* feat(backend-gitlab): implement missing workflow methods

* chore: fix lint error

* feat(backend-gitlab): support files deletion

* test(e2e): add gitlab cypress tests

* feat(backend-bitbucket): implement missing editorial workflow methods

* test(e2e): add BitBucket backend e2e tests

* build: update node version to 12 on netlify builds

* fix(backend-bitbucket): extract BitBucket avatar url

* test: fix git-gateway AuthenticationPage test

* test(e2e): fix some backend tests

* test(e2e): fix tests

* test(e2e): add git-gateway editorial workflow test

* chore: code cleanup

* test(e2e): revert back to electron

* test(e2e): add non editorial workflow tests

* fix(git-gateway-gitlab): don't call unpublishedEntry in simple workflow

gitlab git-gateway doesn't support editorial workflow APIs yet. This change makes sure not to call them in simple workflow

* refactor(backend-bitbucket): switch to diffstat API instead of raw diff

* chore: fix test

* test(e2e): add more git-gateway tests

* fix: post rebase typescript fixes

* test(e2e): fix tests

* fix: fix parsing of content key and add tests

* refactor: rename test file

* test(unit): add getStatues unit tests

* chore: update cypress

* docs: update beta docs

packages/netlify-cms-backend-gitlab/src/__tests__/API.spec.js

@@ -0,0 +1,35 @@
+import API from '../API';
+
+global.fetch = jest.fn().mockRejectedValue(new Error('should not call fetch inside tests'));
+
+describe('GitLab API', () => {
+  beforeEach(() => {
+    jest.resetAllMocks();
+  });
+
+  test('should get preview statuses', async () => {
+    const api = new API({ repo: 'repo' });
+
+    const mr = { sha: 'sha' };
+    const statuses = [
+      { name: 'deploy', status: 'success', target_url: 'deploy-url' },
+      { name: 'build', status: 'pending' },
+    ];
+
+    api.getBranchMergeRequest = jest.fn(() => Promise.resolve(mr));
+    api.getMergeRequestStatues = jest.fn(() => Promise.resolve(statuses));
+
+    const collectionName = 'posts';
+    const slug = 'title';
+    await expect(api.getStatuses(collectionName, slug)).resolves.toEqual([
+      { context: 'deploy', state: 'success', target_url: 'deploy-url' },
+      { context: 'build', state: 'other' },
+    ]);
+
+    expect(api.getBranchMergeRequest).toHaveBeenCalledTimes(1);
+    expect(api.getBranchMergeRequest).toHaveBeenCalledWith('cms/posts/title');
+
+    expect(api.getMergeRequestStatues).toHaveBeenCalledTimes(1);
+    expect(api.getMergeRequestStatues).toHaveBeenCalledWith(mr, 'cms/posts/title');
+  });
+});

packages/netlify-cms-backend-gitlab/src/__tests__/gitlab.spec.js

@@ -1,6 +1,5 @@
 jest.mock('netlify-cms-core/src/backend');
 import { fromJS } from 'immutable';
-import { partial } from 'lodash';
 import { oneLine, stripIndent } from 'common-tags';
 import nock from 'nock';
 import { Cursor } from 'netlify-cms-lib-util';
@@ -175,7 +174,7 @@ describe('gitlab backend', () => {
   }
 
   function mockApi(backend) {
-    return nock(backend.implementation.api_root);
+    return nock(backend.implementation.apiRoot);
   }
 
   function interceptAuth(backend, { userResponse, projectResponse } = {}) {
@@ -206,7 +205,7 @@ describe('gitlab backend', () => {
   function createHeaders(backend, { basePath, path, page, perPage, pageCount, totalCount }) {
     const pageNum = parseInt(page, 10);
     const pageCountNum = parseInt(pageCount, 10);
-    const url = `${backend.implementation.api_root}${basePath}`;
+    const url = `${backend.implementation.apiRoot}${basePath}`;
     const link = linkPage =>
       `<${url}?id=${expectedRepo}&page=${linkPage}&path=${path}&per_page=${perPage}&recursive=false>`;
 
@@ -286,18 +285,8 @@ describe('gitlab backend', () => {
     });
   }
 
-  it('throws if configuration requires editorial workflow', () => {
-    const resolveBackendWithWorkflow = partial(resolveBackend, {
-      ...defaultConfig,
-      publish_mode: 'editorial_workflow',
-    });
-    expect(resolveBackendWithWorkflow).toThrowErrorMatchingInlineSnapshot(
-      `"The GitLab backend does not support the Editorial Workflow."`,
-    );
-  });
-
   it('throws if configuration does not include repo', () => {
-    expect(resolveBackend).toThrowErrorMatchingInlineSnapshot(
+    expect(() => resolveBackend({ backend: {} })).toThrowErrorMatchingInlineSnapshot(
       `"The GitLab backend needs a \\"repo\\" in the backend configuration."`,
     );
   });
@@ -382,7 +371,12 @@ describe('gitlab backend', () => {
       interceptCollection(backend, collectionContentConfig);
 
       const entry = await backend.getEntry(
-        { config: fromJS({}), integrations: fromJS([]), entryDraft: fromJS({}) },
+        {
+          config: fromJS({}),
+          integrations: fromJS([]),
+          entryDraft: fromJS({}),
+          mediaLibrary: fromJS({}),
+        },
         fromJS(collectionContentConfig),
         slug,
       );