From 6933bf6ee1acbbefb2cc7840a8aef6accc2d455b Mon Sep 17 00:00:00 2001 From: Erez Rokah Date: Sun, 5 Apr 2020 16:46:26 +0300 Subject: [PATCH] fix: missing widgets (#3541) --- .../src/lib/__tests__/registry.spec.js | 22 ------------------- packages/netlify-cms-core/src/lib/registry.js | 11 +--------- 2 files changed, 1 insertion(+), 32 deletions(-) diff --git a/packages/netlify-cms-core/src/lib/__tests__/registry.spec.js b/packages/netlify-cms-core/src/lib/__tests__/registry.spec.js index 6e8f5690..92d8a83c 100644 --- a/packages/netlify-cms-core/src/lib/__tests__/registry.spec.js +++ b/packages/netlify-cms-core/src/lib/__tests__/registry.spec.js @@ -147,26 +147,4 @@ describe('registry', () => { }); }); }); - - describe('getWidget', () => { - it('should throw on missing widget', () => { - const { getWidget } = require('../registry'); - - expect(() => getWidget('Unknown')).toThrow( - new Error( - `Could not find widget 'Unknown'. Please make sure the widget name is configured correctly or register it via 'registerwidget'.`, - ), - ); - }); - - it('should throw on missing widget and suggest lowercase name', () => { - const { getWidget, registerWidget } = require('../registry'); - - registerWidget('string', {}); - - expect(() => getWidget('String')).toThrow( - new Error(`Could not find widget 'String'. Did you mean 'string'?`), - ); - }); - }); }); diff --git a/packages/netlify-cms-core/src/lib/registry.js b/packages/netlify-cms-core/src/lib/registry.js index eed8c150..53ee4bb8 100644 --- a/packages/netlify-cms-core/src/lib/registry.js +++ b/packages/netlify-cms-core/src/lib/registry.js @@ -113,16 +113,7 @@ export function registerWidget(name, control, preview) { } } export function getWidget(name) { - const widget = registry.widgets[name]; - if (!widget) { - const nameLowerCase = name.toLowerCase(); - const hasLowerCase = !!registry.widgets[nameLowerCase]; - const message = hasLowerCase - ? `Could not find widget '${name}'. Did you mean '${nameLowerCase}'?` - : `Could not find widget '${name}'. Please make sure the widget name is configured correctly or register it via 'registerwidget'.`; - throw new Error(message); - } - return widget; + return registry.widgets[name]; } export function getWidgets() { return produce(Object.entries(registry.widgets), draft => {