gcg/static-cms
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(netlify-cms-core): validate nested fields (#1873)

Browse Source
This commit is contained in:
Bartholomew
2019-02-05 23:27:34 +01:00
committed by Shawn Erquhart
parent ade5809dff
commit 627e600d29
10 changed files with 183 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
cypress/integration/editorial_workflow_spec.js
View File

@ -4,11 +4,14 @@ describe('Editorial Workflow', () => {
const entry1 = { title: 'first title', body: 'first body' }
const entry2 = { title: 'second title', body: 'second body' }
const entry3 = { title: 'third title', body: 'third body' }
const setting1 = { limit: 10, author: 'John Doe' }
const setting2 = { name: 'Andrew Wommack', description: 'A Gospel Teacher' }
const notifications = {
saved: 'Entry saved',
published: 'Entry published',
updated: 'Entry status updated',
deletedUnpublished: 'Unpublished changes deleted',
error: { missingField: 'Oops, you\'ve missed a required field. Please complete before saving.' }
}
describe('Test Backend', () => {
@ -27,6 +30,29 @@ describe('Editorial Workflow', () => {
assertNotification(notifications.saved)
}
function validateObjectFields({ limit, author }) {
cy.get('a[href^="#/collections/settings"]').click()
cy.get('a[href^="#/collections/settings/entries/general"]').click()
cy.get('input[type=number]').type(limit);
cy.contains('button', 'Save').click()
assertNotification(notifications.error.missingField)
cy.contains('label', 'Default Author').click()
cy.focused().type(author)
cy.contains('button', 'Save').click()
assertNotification(notifications.saved)
}
function validateListFields({ name, description }) {
cy.get('a[href^="#/collections/settings"]').click()
cy.get('a[href^="#/collections/settings/entries/authors"]').click()
cy.contains('button', 'Add').click()
cy.contains('button', 'Save').click()
assertNotification(notifications.error.missingField)
cy.get('input').eq(2).type(name)
cy.get('[data-slate-editor]').eq(2).type(description)
cy.contains('button', 'Save').click()
}
function exitEditor() {
cy.contains('a[href^="#/collections/"]', 'Writing in').click()
}
@ -70,6 +96,16 @@ describe('Editorial Workflow', () => {
exitEditor()
}
function validateObjectFieldsAndExit(setting) {
validateObjectFields(setting)
exitEditor()
}
function validateListFieldsAndExit(setting) {
validateListFields(setting)
exitEditor()
}
function goToWorkflow() {
cy.contains('a', 'Workflow').click()
}
@ -172,6 +208,16 @@ describe('Editorial Workflow', () => {
createPostAndExit(entry1)
})
it('can validate object fields', () => {
login()
validateObjectFieldsAndExit(setting1)
})
it('can validate list fields', () => {
login()
validateListFieldsAndExit(setting2)
})
it('can publish an editorial workflow entry', () => {
login()
createPostAndExit(entry1)