feat: bundle assets with content (#2958)

* fix(media_folder_relative): use collection name in unpublished entry

* refactor: pass arguments as object to AssetProxy ctor

* feat: support media folders per collection

* feat: resolve media files path based on entry path

* fix: asset public path resolving

* refactor: introduce typescript for AssetProxy

* refactor: code cleanup

* refactor(asset-proxy): add tests,switch to typescript,extract arguments

* refactor: typescript for editorialWorkflow

* refactor: add typescript for media library actions

* refactor: fix type error on map set

* refactor: move locale selector into reducer

* refactor: add typescript for entries actions

* refactor: remove duplication between asset store and media lib

* feat: load assets from backend using API

* refactor(github): add typescript, cache media files

* fix: don't load media URL if already loaded

* feat: add media folder config to collection

* fix: load assets from API when not in UI state

* feat: load entry media files when opening media library

* fix: editorial workflow draft media files bug fixes

* test(unit): fix unit tests

* fix: editor control losing focus

* style: add eslint object-shorthand rule

* test(cypress): re-record mock data

* fix: fix non github backends, large media

* test: uncomment only in tests

* fix(backend-test): add missing displayURL property

* test(e2e): add media library tests

* test(e2e): enable visual testing

* test(e2e): add github backend media library tests

* test(e2e): add git-gateway large media tests

* chore: post rebase fixes

* test: fix tests

* test: fix tests

* test(cypress): fix tests

* docs: add media_folder docs

* test(e2e): add media library delete test

* test(e2e): try and fix image comparison on CI

* ci: reduce test machines from 9 to 8

* test: add reducers and selectors unit tests

* test(e2e): disable visual regression testing for now

* test: add getAsset unit tests

* refactor: use Asset class component instead of hooks

* build: don't inline source maps

* test: add more media path tests

packages/netlify-cms-backend-bitbucket/src/API.js

@@ -150,7 +150,7 @@ export default class API {
     return this.processFiles(entries);
   };
 
-  uploadBlob = async (item, { commitMessage, branch = this.branch } = {}) => {
+  uploadBlob = (item, { commitMessage, branch = this.branch } = {}) => {
     const contentBlob = get(item, 'fileObj', new Blob([item.raw]));
     const formData = new FormData();
     // Third param is filename header, in case path is `message`, `branch`, etc.
@@ -168,16 +168,12 @@ export default class API {
       unsentRequest.withMethod('POST'),
       unsentRequest.withBody(formData),
       this.request,
-      then(() => ({ ...item, uploaded: true })),
+      then(() => ({ ...item })),
     ])(`${this.repoURL}/src`);
   };
 
   persistFiles = (files, { commitMessage }) =>
-    Promise.all(
-      files
-        .filter(({ uploaded }) => !uploaded)
-        .map(file => this.uploadBlob(file, { commitMessage })),
-    );
+    Promise.all(files.map(file => this.uploadBlob(file, { commitMessage })));
 
   deleteFile = (path, message, { branch = this.branch } = {}) => {
     const body = new FormData();

packages/netlify-cms-backend-bitbucket/src/implementation.js

@@ -7,6 +7,8 @@ import {
   resolvePromiseProperties,
   then,
   unsentRequest,
+  basename,
+  getBlobSHA,
 } from 'netlify-cms-lib-util';
 import { NetlifyAuthenticator } from 'netlify-cms-lib-auth';
 import AuthenticationPage from './AuthenticationPage';
@@ -225,21 +227,24 @@ export default class BitbucketBackend {
     }));
   }
 
-  getMedia() {
+  getMedia(mediaFolder = this.config.get('media_folder')) {
     return this.api
-      .listAllFiles(this.config.get('media_folder'))
+      .listAllFiles(mediaFolder)
       .then(files =>
         files.map(({ id, name, path }) => ({ id, name, path, displayURL: { id, path } })),
       );
   }
 
+  getMediaAsBlob(path, id) {
+    return this.api.readFile(path, id, { parseText: false });
+  }
+
   getMediaDisplayURL(displayURL) {
     this._mediaDisplayURLSem = this._mediaDisplayURLSem || semaphore(MAX_CONCURRENT_DOWNLOADS);
     const { id, path } = displayURL;
     return new Promise((resolve, reject) =>
       this._mediaDisplayURLSem.take(() =>
-        this.api
-          .readFile(path, id, { parseText: false })
+        this.getMediaAsBlob(path, id)
           .then(blob => URL.createObjectURL(blob))
           .then(resolve, reject)
           .finally(() => this._mediaDisplayURLSem.leave()),
@@ -247,14 +252,45 @@ export default class BitbucketBackend {
     );
   }
 
+  async getMediaFile(path) {
+    const name = basename(path);
+    const blob = await this.getMediaAsBlob(path, null);
+    const fileObj = new File([blob], name);
+    const url = URL.createObjectURL(fileObj);
+
+    return {
+      displayURL: url,
+      path,
+      name,
+      size: fileObj.size,
+      file: fileObj,
+      url,
+    };
+  }
+
   persistEntry(entry, mediaFiles, options = {}) {
     return this.api.persistFiles([entry], options);
   }
 
   async persistMedia(mediaFile, options = {}) {
-    await this.api.persistFiles([mediaFile], options);
-    const { value, path, fileObj } = mediaFile;
-    return { name: value, size: fileObj.size, path: trimStart(path, '/k') };
+    const { fileObj } = mediaFile;
+
+    const [sha] = await Promise.all([
+      getBlobSHA(fileObj),
+      this.api.persistFiles([mediaFile], options),
+    ]);
+
+    const url = URL.createObjectURL(fileObj);
+
+    return {
+      displayURL: url,
+      path: trimStart(mediaFile.path, '/k'),
+      name: fileObj.name,
+      size: fileObj.size,
+      id: sha,
+      file: fileObj,
+      url,
+    };
   }
 
   deleteFile(path, commitMessage, options) {