From 1f06885a6960ee81548e1911c836003d2277ec03 Mon Sep 17 00:00:00 2001 From: Darrel O'Pry Date: Wed, 20 Sep 2017 15:23:40 -0400 Subject: [PATCH] Add code coverage output generation to npm test (#610) --- .gitignore | 2 ++ package.json | 8 ++++++-- .../Widgets/Markdown/serializers/remarkPaddedLinks.js | 10 +++++++++- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index e0329013..1824b939 100644 --- a/.gitignore +++ b/.gitignore @@ -8,3 +8,5 @@ yarn-error.log .vscode/ manifest.yml .imdone/ + +/coverage/ diff --git a/package.json b/package.json index 56d1dbd8..3f95b716 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "main": "dist/cms.js", "scripts": { "start": "webpack-dev-server -d --config webpack.dev.js", - "test": "jest", + "test": "jest --coverage", "test:watch": "jest --watch", "build": "cross-env NODE_ENV=production webpack --config webpack.prod.js --display-error-details", "build:scripts": "cross-env NODE_ENV=production webpack --config webpack.cli.js", @@ -39,7 +39,11 @@ "moduleNameMapper": { "^.+\\.(png|eot|woff|woff2|ttf|svg|gif)$": "/__mocks__/fileLoaderMock.js", "^.+\\.s?css$": "/__mocks__/styleLoaderMock.js" - } + }, + "mapCoverage": true, + "coverageReporters": ["lcov"], + "collectCoverageFrom": [ "src/**/*.js" ], + "coveragePathIgnorePatterns": [ "/__tests__/" ] }, "keywords": [ "netlify", diff --git a/src/components/Widgets/Markdown/serializers/remarkPaddedLinks.js b/src/components/Widgets/Markdown/serializers/remarkPaddedLinks.js index 7b2b752b..7bdd0b66 100644 --- a/src/components/Widgets/Markdown/serializers/remarkPaddedLinks.js +++ b/src/components/Widgets/Markdown/serializers/remarkPaddedLinks.js @@ -97,7 +97,15 @@ export default function remarkPaddedLinks() { * nesting. If `end` is truthy, get the last node, otherwise first. */ function getEdgeTextChild(node, end) { - const findFn = end ? findLast : find; + /** + * This was changed from a ternary to a long form if due to issues with istanbul's instrumentation and babel's code + * generation. + * TODO: watch https://github.com/istanbuljs/babel-plugin-istanbul/issues/95 + * when it is resolved then revert to ```const findFn = end ? findLast : find;``` + */ + let findFn; + if (end) { findFn = findLast } + else { findFn = find }; let edgeChildWithValue; setEdgeChildWithValue(node);