improvement: add logs when a 404 error is expected (#2807)
improvement: add logs when a 404 error is expected improvement: address code review feedback -return rejected promise
This commit is contained in:
@ -14,7 +14,14 @@ import {
|
||||
|
||||
const CMS_BRANCH_PREFIX = 'cms';
|
||||
|
||||
const replace404WithEmptyArray = err => (err && err.status === 404 ? [] : Promise.reject(err));
|
||||
const replace404WithEmptyArray = err => {
|
||||
if (err && err.status === 404) {
|
||||
console.log('This 404 was expected and handled appropriately.');
|
||||
return [];
|
||||
} else {
|
||||
return Promise.reject(err);
|
||||
}
|
||||
};
|
||||
|
||||
export default class API {
|
||||
constructor(config) {
|
||||
|
@ -107,7 +107,14 @@ export default class GitHub {
|
||||
headers: { Authorization: `token ${token}` },
|
||||
})
|
||||
.then(() => true)
|
||||
.catch(err => (err && err.status === 404 ? false : Promise.reject(err)));
|
||||
.catch(err => {
|
||||
if (err && err.status === 404) {
|
||||
console.log('This 404 was expected and handled appropriately.');
|
||||
return false;
|
||||
} else {
|
||||
return Promise.reject(err);
|
||||
}
|
||||
});
|
||||
// wait between polls
|
||||
if (!repoExists) {
|
||||
await new Promise(resolve => setTimeout(resolve, pollDelay));
|
||||
|
Reference in New Issue
Block a user