gcg/static-cms
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

improvement: add logs when a 404 error is expected (#2807)

Browse Source 
improvement: add logs when a 404 error is expected

improvement: address code review feedback -return rejected promise
This commit is contained in:
ed ho
2019-11-10 00:34:03 -08:00
committed by Erez Rokah
parent 542a7acfe6
commit 1d78a2705f
4 changed files with 32 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/netlify-cms-backend-git-gateway/src/implementation.js
View File

@ -256,7 +256,14 @@ export default class GitGateway {
.readFile('.gitattributes')
.then(getLargeMediaPatternsFromGitAttributesFile)
.then(patterns => ({ patterns }))
.catch(err => (err.message.includes('404') ? [] : { err }));
.catch(err => {
if (err.message.includes('404')) {
console.log('This 404 was expected and handled appropriately.');
return [];
} else {
return { err };
}
});
return Promise.all([netlifyLargeMediaEnabledPromise, lfsPatternsPromise]).then(
([{ enabled: maybeEnabled }, { patterns, err: patternsErr }]) => {