Test: add editor test coverage (#3598)

This commit is contained in:
Erez Rokah 2020-04-14 11:18:48 +03:00 committed by GitHub
parent 36ae69c96e
commit 166b070cb1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 288 additions and 73 deletions

View File

@ -21,9 +21,12 @@ import {
unpublishEntry,
publishEntryInEditor,
duplicateEntry,
goToEntry,
populateEntry,
publishAndCreateNewEntryInEditor,
publishAndDuplicateEntryInEditor,
} from '../utils/steps';
import { setting1, setting2, workflowStatus, editorStatus, publishTypes } from '../utils/constants';
import { fromJS } from 'immutable';
const entry1 = {
title: 'first title',
@ -54,7 +57,17 @@ describe('Test Backend Editorial Workflow', () => {
it('can create an entry', () => {
login();
createPostAndExit(entry1);
createPost(entry1);
// new entry should show 'Delete unpublished entry'
cy.contains('button', 'Delete unpublished entry');
cy.url().should(
'eq',
`http://localhost:8080/#/collections/posts/entries/1970-01-01-${entry1.title
.toLowerCase()
.replace(/\s/, '-')}`,
);
exitEditor();
});
it('can validate object fields', () => {
@ -80,6 +93,27 @@ describe('Test Backend Editorial Workflow', () => {
publishWorkflowEntry(entry1);
});
it('can update an entry', () => {
login();
createPostAndExit(entry1);
goToWorkflow();
updateWorkflowStatus(entry1, workflowStatus.draft, workflowStatus.ready);
publishWorkflowEntry(entry1);
goToEntry(entry1);
populateEntry(entry2);
// existing entry should show 'Delete unpublished changes'
cy.contains('button', 'Delete unpublished changes');
// existing entry slug should remain the same after save'
cy.url().should(
'eq',
`http://localhost:8080/#/collections/posts/entries/1970-01-01-${entry1.title
.toLowerCase()
.replace(/\s/, '-')}`,
);
exitEditor();
});
it('can change workflow status', () => {
login();
createPostAndExit(entry1);
@ -148,58 +182,8 @@ describe('Test Backend Editorial Workflow', () => {
});
it('cannot publish when "publish" is false', () => {
cy.visit('/', {
onBeforeLoad: window => {
window.CMS_MANUAL_INIT = true;
},
onLoad: window => {
window.CMS.init({
config: fromJS({
backend: {
name: 'test-repo',
},
publish_mode: 'editorial_workflow',
load_config_file: false,
media_folder: 'assets/uploads',
collections: [
{
label: 'Posts',
name: 'post',
folder: '_posts',
label_singular: 'Post',
create: true,
publish: false,
fields: [
{ label: 'Title', name: 'title', widget: 'string', tagname: 'h1' },
{
label: 'Publish Date',
name: 'date',
widget: 'datetime',
dateFormat: 'YYYY-MM-DD',
timeFormat: 'HH:mm',
format: 'YYYY-MM-DD HH:mm',
},
{
label: 'Cover Image',
name: 'image',
widget: 'image',
required: false,
tagname: '',
},
{
label: 'Body',
name: 'body',
widget: 'markdown',
hint: 'Main content goes here.',
},
],
},
],
}),
});
},
});
cy.contains('button', 'Login').click();
cy.task('updateConfig', { collections: [{ publish: false }] });
login();
createPost(entry1);
cy.contains('span', 'Publish').should('not.exist');
exitEditor();
@ -207,4 +191,19 @@ describe('Test Backend Editorial Workflow', () => {
updateWorkflowStatus(entry1, workflowStatus.draft, workflowStatus.ready);
cy.contains('button', 'Publish new entry').should('not.exist');
});
it.only('can create a new entry, publish and create new', () => {
login();
createPost(entry1);
updateWorkflowStatusInEditor(editorStatus.ready);
publishAndCreateNewEntryInEditor(entry1);
});
it.only('can create a new entry, publish and duplicate', () => {
login();
createPost(entry1);
updateWorkflowStatusInEditor(editorStatus.ready);
publishAndDuplicateEntryInEditor(entry1);
});
});

View File

@ -0,0 +1,101 @@
import {
login,
newPost,
populateEntry,
exitEditor,
createPostAndPublish,
assertPublishedEntry,
editPostAndPublish,
createPostPublishAndCreateNew,
createPostPublishAndDuplicate,
editPostPublishAndCreateNew,
editPostPublishAndDuplicate,
duplicatePostAndPublish,
} from '../utils/steps';
const entry1 = {
title: 'first title',
body: 'first body',
};
const entry2 = {
title: 'second title',
body: 'second body',
};
const backend = 'test';
describe('Test Backend Simple Workflow', () => {
before(() => {
Cypress.config('defaultCommandTimeout', 4000);
cy.task('setupBackend', { backend, options: { publish_mode: 'simple' } });
});
after(() => {
cy.task('teardownBackend', { backend });
});
it('successfully loads', () => {
login();
});
it('can create a new entry', () => {
login();
newPost();
populateEntry(entry1, () => {});
// new entry should show 'Unsaved changes'
cy.contains('div', 'Unsaved Changes');
cy.url().should('eq', `http://localhost:8080/#/collections/posts/new`);
exitEditor();
});
it('can publish a new entry', () => {
login();
createPostAndPublish(entry1);
assertPublishedEntry(entry1);
});
it('can publish a new entry and create new', () => {
login();
createPostPublishAndCreateNew(entry1);
assertPublishedEntry(entry1);
});
it('can publish a new entry and duplicate', () => {
login();
createPostPublishAndDuplicate(entry1);
assertPublishedEntry(entry1);
});
it('can edit an existing entry and publish', () => {
login();
createPostAndPublish(entry1);
assertPublishedEntry(entry1);
editPostAndPublish(entry1, entry2);
});
it('can edit an existing entry, publish and create new', () => {
login();
createPostAndPublish(entry1);
assertPublishedEntry(entry1);
editPostPublishAndCreateNew(entry1, entry2);
});
it('can edit an existing entry, publish and duplicate', () => {
login();
createPostAndPublish(entry1);
assertPublishedEntry(entry1);
editPostPublishAndDuplicate(entry1, entry2);
});
it('can duplicate an existing entry', () => {
login();
createPostAndPublish(entry1);
assertPublishedEntry(entry1);
duplicatePostAndPublish(entry1);
});
});

View File

@ -11,6 +11,7 @@
// This function is called when a project is opened or re-opened (e.g. due to
// the project's config changing)
require('dotenv').config();
const { merge } = require('lodash');
const { addMatchImageSnapshotPlugin } = require('cypress-image-snapshot/plugin');
const {
@ -34,8 +35,8 @@ const {
teardownBitBucketTest,
} = require('./bitbucket');
const { setupProxy, teardownProxy, setupProxyTest, teardownProxyTest } = require('./proxy');
const { copyBackendFiles, switchVersion } = require('../utils/config');
const { setupTestBackend } = require('./testBackend');
const { copyBackendFiles, switchVersion, updateConfig } = require('../utils/config');
module.exports = async (on, config) => {
// `on` is used to hook into various events Cypress emits
@ -61,6 +62,9 @@ module.exports = async (on, config) => {
case 'proxy':
result = await setupProxy(options);
break;
case 'test':
result = await setupTestBackend(options);
break;
}
return result;
@ -161,6 +165,13 @@ module.exports = async (on, config) => {
await switchVersion(version);
return null;
},
async updateConfig(config) {
await updateConfig(current => {
merge(current, config);
});
return null;
},
});

View File

@ -0,0 +1,14 @@
const { updateConfig } = require('../utils/config');
const { merge } = require('lodash');
async function setupTestBackend(options) {
await updateConfig(current => {
merge(current, options);
});
return null;
}
module.exports = {
setupTestBackend,
};

View File

@ -2,7 +2,7 @@ const workflowStatus = { draft: 'Drafts', review: 'In Review', ready: 'Ready' };
const editorStatus = { draft: 'Draft', review: 'In review', ready: 'Ready' };
const setting1 = { limit: 10, author: 'John Doe' };
const setting2 = { name: 'Jane Doe', description: 'description' };
const publishTypes = { publishNow: 'Publish now' };
const publishTypes = { publishNow: 'Publish now', publishAndCreateNew: 'Publish and create new', publishAndDuplicate: 'Publish and duplicate' };
const notifications = {
saved: 'Entry saved',
published: 'Entry published',

View File

@ -169,6 +169,20 @@ function publishEntryInEditor(publishType) {
assertNotification(notifications.published);
}
function publishAndCreateNewEntryInEditor() {
selectDropdownItem('Publish', publishTypes.publishAndCreateNew);
assertNotification(notifications.published);
cy.url().should('eq', `http://localhost:8080/#/collections/posts/new`);
cy.get('[id^="title-field"]').should('have.value', '');
}
function publishAndDuplicateEntryInEditor(entry) {
selectDropdownItem('Publish', publishTypes.publishAndDuplicate);
assertNotification(notifications.published);
cy.url().should('eq', `http://localhost:8080/#/collections/posts/new`);
cy.get('[id^="title-field"]').should('have.value', entry.title);
}
function selectDropdownItem(label, item) {
cy.contains('[role="button"]', label).as('dropDownButton');
cy.get('@dropDownButton')
@ -205,12 +219,11 @@ function populateEntry(entry, onDone = flushClockAndSave) {
if (key === 'body') {
cy.getMarkdownEditor()
.click()
.clear()
.type(value);
.clear({ force: true })
.type(value, { force: true });
} else {
cy.get(`[id^="${key}-field"]`)
.clear()
.type(value);
cy.get(`[id^="${key}-field"]`).clear({ force: true });
cy.get(`[id^="${key}-field"]`).type(value, { force: true });
}
}
@ -231,7 +244,7 @@ function createPostAndExit(entry) {
exitEditor();
}
function publishEntry() {
function publishEntry({ createNew = false, duplicate = false } = {}) {
cy.clock().then(clock => {
// some input fields are de-bounced thus require advancing the clock
if (clock) {
@ -242,23 +255,91 @@ function publishEntry() {
cy.wait(500);
}
cy.contains('[role="button"]', 'Publish').as('publishButton');
cy.get('@publishButton')
.parent()
.within(() => {
cy.get('@publishButton').click();
cy.contains('[role="menuitem"] span', 'Publish now').click();
});
if (createNew) {
selectDropdownItem('Publish', publishTypes.publishAndCreateNew);
} else if (duplicate) {
selectDropdownItem('Publish', publishTypes.publishAndDuplicate);
} else {
selectDropdownItem('Publish', publishTypes.publishNow);
}
assertNotification(notifications.saved);
});
}
function createPostAndPublish(entry) {
cy.contains('a', 'New Post').click();
newPost();
populateEntry(entry, publishEntry);
exitEditor();
}
function createPostPublishAndCreateNew(entry) {
newPost();
populateEntry(entry, () => publishEntry({ createNew: true }));
cy.url().should('eq', `http://localhost:8080/#/collections/posts/new`);
cy.get('[id^="title-field"]').should('have.value', '');
exitEditor();
}
function createPostPublishAndDuplicate(entry) {
newPost();
populateEntry(entry, () => publishEntry({ duplicate: true }));
cy.url().should('eq', `http://localhost:8080/#/collections/posts/new`);
cy.get('[id^="title-field"]').should('have.value', entry.title);
exitEditor();
}
function editPostAndPublish(entry1, entry2) {
goToEntry(entry1);
cy.contains('button', 'Delete entry');
cy.contains('span', 'Published');
populateEntry(entry2, publishEntry);
// existing entry slug should remain the same after save
cy.url().should(
'eq',
`http://localhost:8080/#/collections/posts/entries/1970-01-01-${entry1.title
.toLowerCase()
.replace(/\s/, '-')}`,
);
}
function editPostPublishAndCreateNew(entry1, entry2) {
goToEntry(entry1);
cy.contains('button', 'Delete entry');
cy.contains('span', 'Published');
populateEntry(entry2, () => publishEntry({ createNew: true }));
cy.url().should('eq', `http://localhost:8080/#/collections/posts/new`);
cy.get('[id^="title-field"]').should('have.value', '');
}
function editPostPublishAndDuplicate(entry1, entry2) {
goToEntry(entry1);
cy.contains('button', 'Delete entry');
cy.contains('span', 'Published');
populateEntry(entry2, () => publishEntry({ duplicate: true }));
cy.url().should('eq', `http://localhost:8080/#/collections/posts/new`);
cy.get('[id^="title-field"]').should('have.value', entry2.title);
}
function duplicatePostAndPublish(entry1) {
goToEntry(entry1);
cy.contains('button', 'Delete entry');
selectDropdownItem('Published', 'Duplicate');
publishEntry();
cy.url().should(
'eq',
`http://localhost:8080/#/collections/posts/entries/1970-01-01-${entry1.title
.toLowerCase()
.replace(/\s/, '-')}-1`,
);
}
function updateExistingPostAndExit(fromEntry, toEntry) {
goToWorkflow();
cy.contains('h2', fromEntry.title)
@ -393,4 +474,13 @@ module.exports = {
newPost,
populateEntry,
goToEntry,
publishEntry,
createPostPublishAndCreateNew,
createPostPublishAndDuplicate,
editPostAndPublish,
editPostPublishAndCreateNew,
editPostPublishAndDuplicate,
duplicatePostAndPublish,
publishAndCreateNewEntryInEditor,
publishAndDuplicateEntryInEditor,
};

View File

@ -33,7 +33,7 @@ collections: # A list of collections the CMS should be able to edit
required: false
tagname: ''
- { editorComponents: ['youtube'], label: 'Body', name: 'body', widget: 'markdown', hint: 'Main content goes here.' }
- { label: 'Body', name: 'body', widget: 'markdown', hint: 'Main content goes here.' }
meta:
- { label: 'SEO Description', name: 'description', widget: 'text' }