gcg/static-cms
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(schema): enforce files and collections names uniqueness (#3913)

Browse Source
This commit is contained in:
Erez Rokah 2020-06-18 14:35:02 +03:00 committed by GitHub
parent c65dbc0123
commit 0dc62eabec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/netlify-cms-core/src/constants/configSchema.js
View File

@ -149,6 +149,7 @@ const getConfigSchema = () => ({
}, },
required: ['name', 'label', 'file', 'fields'], required: ['name', 'label', 'file', 'fields'],
}, },
uniqueItemProperties: ['name'],
}, },
identifier_field: { type: 'string' }, identifier_field: { type: 'string' },
summary: { type: 'string' }, summary: { type: 'string' },
@ -229,6 +230,7 @@ const getConfigSchema = () => ({
}, },
}, },
}, },
uniqueItemProperties: ['name'],
}, },
}, },
required: ['backend', 'collections'], required: ['backend', 'collections'],
@ -279,7 +281,15 @@ export function validateConfig(config) {
const errors = ajv.errors.map(e => { const errors = ajv.errors.map(e => {
// TODO: remove after https://github.com/ajv-validator/ajv-keywords/pull/123 is merged // TODO: remove after https://github.com/ajv-validator/ajv-keywords/pull/123 is merged
if (e.keyword === 'uniqueItemProperties') { if (e.keyword === 'uniqueItemProperties') {
const newError = { ...e, message: 'fields names must be unique' }; const path = e.dataPath || '';
let newError = e;
if (path.endsWith('/fields')) {
newError = { ...e, message: 'fields names must be unique' };
} else if (path.endsWith('/files')) {
newError = { ...e, message: 'files names must be unique' };
} else if (path.endsWith('/collections')) {
newError = { ...e, message: 'collections names must be unique' };
}
return newError; return newError;
} }
return e; return e;